Moves PerKeyCombineFnRunners back to runners-core#1798
Merged
asfgit merged 1 commit intoapache:masterfrom Jan 19, 2017
Merged
Conversation
It is used by the Dataflow worker. However, this change moves only the non-OldDoFn related part to runners-core. The OldDoFn-related part stays in Flink.
Member
|
Since this is not exercised in the Dataflow postcommit (sad face) I have not run it. I kicked off Flink postcommit at https://builds.apache.org/view/Beam/job/beam_PostCommit_Java_RunnableOnService_Flink/1392/ Overall concept LGTM and I'll take a peek at the code and merge shortly if I don't see any problems. |
|
Refer to this link for build results (access rights to CI server needed): |
Member
|
Postcommit passes as do real tests. The coveralls details link does not provide any useful details; it is a misconfiguration that it makes the build red IMO. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is used by the Dataflow worker.
However, this change moves only the non-OldDoFn related part
to runners-core. The OldDoFn-related part stays in Flink.
R: @kennknowles