[BEAM-646] Add ReplaceOutputs to PTransformOverrideFactory#1995
Closed
tgroh wants to merge 1 commit intoapache:masterfrom
Closed
[BEAM-646] Add ReplaceOutputs to PTransformOverrideFactory#1995tgroh wants to merge 1 commit intoapache:masterfrom
tgroh wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
R: @kennknowles |
kennknowles
reviewed
Feb 13, 2017
| /** | ||
| * Returns a {@link Map} from the expanded values in {@code newOutput} to the values produced by | ||
| * the original transform. | ||
| * |
Member
There was a problem hiding this comment.
(you said this to me out loud just now): "Not necessarily, because if you know they are the same semantic thing, you can merge them"
Member
|
LGTM |
|
Refer to this link for build results (access rights to CI server needed): |
This maps the outputs produced by applying a Replacement PTransform to the outputs produced by the original PTransform.
tgroh
force-pushed
the
replacement_output
branch
from
f46459d to
a26ece5
Compare
|
Refer to this link for build results (access rights to CI server needed): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
This maps the outputs produced by applying a Replacement PTransform to
the outputs produced by the original PTransform.