Skip to content

Comments

[BEAM-115] Add convenience for wrapping up a self contained message that has references in it#2023

Merged
asfgit merged 1 commit intoapache:masterfrom
kennknowles:Pipeline-components
Feb 16, 2017
Merged

[BEAM-115] Add convenience for wrapping up a self contained message that has references in it#2023
asfgit merged 1 commit intoapache:masterfrom
kennknowles:Pipeline-components

Conversation

@kennknowles
Copy link
Member

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@kennknowles
Copy link
Member Author

R: @bjchambers thanks for the consult on this
CC: @tgroh also thanks

Copy link
Member

@tgroh tgroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 30897be on kennknowles:Pipeline-components into ** on apache:master**.

message Pipeline {

// A set of mappings from id to message. This is included as an optional field
// on any proto message that may contain references needing resolution.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add something like:

MessageWithComponents serves as a general container for a Components map and a specific message that may contain references.

@asfbot
Copy link

asfbot commented Feb 16, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7494/
--none--

@asfgit asfgit merged commit 368ad23 into apache:master Feb 16, 2017
asfgit pushed a commit that referenced this pull request Feb 16, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 368ad23 on kennknowles:Pipeline-components into ** on apache:master**.

@asfbot
Copy link

asfbot commented Feb 16, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7498/
--none--

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 368ad23 on kennknowles:Pipeline-components into ** on apache:master**.

@asfbot
Copy link

asfbot commented Feb 16, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7499/
--none--

@kennknowles kennknowles deleted the Pipeline-components branch March 31, 2017 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants