Skip to content

[BEAM-1621] Add streaming executions to examples/java integration tests#2155

Merged
asfgit merged 1 commit intoapache:masterfrom
kennknowles:streaming-example-ITs
Mar 20, 2017
Merged

[BEAM-1621] Add streaming executions to examples/java integration tests#2155
asfgit merged 1 commit intoapache:masterfrom
kennknowles:streaming-example-ITs

Conversation

@kennknowles
Copy link
Member

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.894% when pulling 00a0ff8a4c8058f06209811bb31fc9594e90916e on kennknowles:streaming-example-ITs into 1783819 on apache:master.

@asfbot
Copy link

asfbot commented Mar 3, 2017

@kennknowles kennknowles force-pushed the streaming-example-ITs branch from 00a0ff8 to b58117c Compare March 3, 2017 23:45
@kennknowles
Copy link
Member Author

R: @davorbonaci @jasonkuster this isn't great if the JVM gets killed, but on balance I am for adding this minimal coverage now and improving the safety later

CC: @tgroh looks like this would be enough to catch the streaming side input issue. Rebased on top of your fix.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 70.101% when pulling b58117c on kennknowles:streaming-example-ITs into 3fde7b2 on apache:master.

@asfbot
Copy link

asfbot commented Mar 4, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8099/
--none--

Copy link
Member

@davorbonaci davorbonaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@asfgit asfgit merged commit b58117c into apache:master Mar 20, 2017
asfgit pushed a commit that referenced this pull request Mar 20, 2017
@kennknowles kennknowles deleted the streaming-example-ITs branch March 31, 2017 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments