[BEAM-1621] Add streaming executions to examples/java integration tests#2155
Merged
asfgit merged 1 commit intoapache:masterfrom Mar 20, 2017
Merged
[BEAM-1621] Add streaming executions to examples/java integration tests#2155asfgit merged 1 commit intoapache:masterfrom
asfgit merged 1 commit intoapache:masterfrom
Conversation
|
Coverage remained the same at 69.894% when pulling 00a0ff8a4c8058f06209811bb31fc9594e90916e on kennknowles:streaming-example-ITs into 1783819 on apache:master. |
|
Refer to this link for build results (access rights to CI server needed): Failed Tests: 1beam_PreCommit_Java_MavenInstall/org.apache.beam:beam-examples-java: 1--none-- |
00a0ff8 to
b58117c
Compare
Member
Author
|
R: @davorbonaci @jasonkuster this isn't great if the JVM gets killed, but on balance I am for adding this minimal coverage now and improving the safety later CC: @tgroh looks like this would be enough to catch the streaming side input issue. Rebased on top of your fix. |
|
Refer to this link for build results (access rights to CI server needed): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.