Skip to content

Do not allow postcommit jobs phrase triggering #21821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kennknowles merged 1 commit into from
Jun 13, 2022
Merged

Do not allow postcommit jobs phrase triggering #21821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .test-infra/jenkins/PostcommitJobBuilder.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class PostcommitJobBuilder {
* Set the job details.
*
* @param nameBase Job name for the postcommit job, a _PR suffix added if the trigger is set.
* @param triggerPhrase Phrase to trigger jobs, empty to not have a trigger.
* @param triggerPhrase Phrase to trigger jobs, IGNORED.
* @param githubUiHint Short description in the github UI.
* @param scope Delegate for the job.
* @param jobDefinition Closure for the job.
Expand All @@ -51,9 +51,6 @@ class PostcommitJobBuilder {
jobDefinition = {}) {
PostcommitJobBuilder jb = new PostcommitJobBuilder(scope, jobDefinition)
jb.defineAutoPostCommitJob(nameBase)
if (triggerPhrase) {
jb.defineGhprbTriggeredJob(nameBase + "_PR", triggerPhrase, githubUiHint, false)
}
}

void defineAutoPostCommitJob(name) {
Expand Down