TestFlinkRunner calls waitUntilFinish() #2240
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Run Flink RunnableOnService |
Contributor
Author
tgroh
reviewed
Mar 14, 2017
| PipelineResult result = delegate.run(pipeline); | ||
| // For tests that don't call waitUntilFinish(). | ||
| try { | ||
| result.waitUntilFinish(Duration.standardSeconds(30)); |
Member
There was a problem hiding this comment.
Why this duration?
Also the nested tries and catches and exception propagation make my head hurt a little. I'm not sure off the top of my head if there's any other way to do it.
You should also consider only calling cancel if the job has not already terminated.
Also it turns out the FlinkRunner doesn't support cancel
|
Refer to this link for build results (access rights to CI server needed): Build result: FAILURE[...truncated 2.01 MB...] at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) ... 31 moreCaused by: java.lang.RuntimeException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?Command was /bin/sh -c cd /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall@2/examples/java && /usr/local/asfpackages/java/jdk1.8.0_121/jre/bin/java '-javaagent:/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall@2/.repository/org/jacoco/org.jacoco.agent/0.7.8/org.jacoco.agent-0.7.8-runtime.jar=destfile=/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall@2/examples/java/target/jacoco.exec,excludes=**/AutoValue_*.class,dumponexit=true,output=file' org.apache.maven.surefire.booter.ForkedBooter /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall@2/examples/java/target/surefire/surefire6523076267554836978tmp /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall@2/examples/java/target/surefire/surefire_45380878666354083519tmp at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:590) at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:460) at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:229) at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:201) at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1026) at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:862) at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:755) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) ... 32 more2017-03-14T01:03:40.288 [ERROR] 2017-03-14T01:03:40.288 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-03-14T01:03:40.288 [ERROR] 2017-03-14T01:03:40.288 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-03-14T01:03:40.288 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException2017-03-14T01:03:40.288 [ERROR] 2017-03-14T01:03:40.288 [ERROR] After correcting the problems, you can resume the build with the command2017-03-14T01:03:40.288 [ERROR] mvn -rf :beam-examples-javachannel stoppedSetting status of 784f708 to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8373/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install--none-- |
Contributor
Author
|
This PR is irrelevant cause Flink internally waits for the pipeline to finish; closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @tgroh
Will file JIRA now.