-
Notifications
You must be signed in to change notification settings - Fork 4.5k
fix minor unreachable code caused by log.Fatal (#22618) #22719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22719 +/- ##
=======================================
Coverage 74.20% 74.20%
=======================================
Files 710 710
Lines 93547 93547
=======================================
Hits 69413 69413
Misses 22857 22857
Partials 1277 1277
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
1e7d155 to
db3eec0
Compare
|
Assigning reviewers. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Reminder, please take a look at this pr: @robertwb @ahmedabu98 |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @kileys for label java. Available commands:
|
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @lukecwik for label java. Available commands:
|
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @kennknowles for label java. Available commands:
|
|
Reminder, please take a look at this pr: @kennknowles @pabloem |
|
I'm so sorry about the delay @Naireen ! should we get this fixed and ready to go? |
|
Reminder, please take a look at this pr: @kennknowles @pabloem |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @apilloud for label java. Available commands:
|
|
r: @pabloem as he has started on the review here |
|
@Naireen - what should we do about this PR? |
|
I chatted with the author. She wants to have it closed, so we'll do that. |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Add sink changes to support #16366
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.