Skip to content

Conversation

@Naireen
Copy link
Contributor

@Naireen Naireen commented Aug 15, 2022

Add sink changes to support #16366


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #22719 (d3ba73b) into master (d3ba73b) will not change coverage.
The diff coverage is n/a.

❗ Current head d3ba73b differs from pull request most recent head db3eec0. Consider uploading reports for the commit db3eec0 to get more accurate results

@@           Coverage Diff           @@
##           master   #22719   +/-   ##
=======================================
  Coverage   74.20%   74.20%           
=======================================
  Files         710      710           
  Lines       93547    93547           
=======================================
  Hits        69413    69413           
  Misses      22857    22857           
  Partials     1277     1277           
Flag Coverage Δ
go 51.54% <0.00%> (ø)
python 83.60% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Naireen Naireen force-pushed the java_worker_pubsub branch from 1e7d155 to db3eec0 Compare August 15, 2022 02:00
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @ahmedabu98 for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @robertwb @ahmedabu98

@github-actions
Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @kileys for label java.
R: @pabloem for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

Reminder, please take a look at this pr: @kileys @pabloem

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @lukecwik for label java.
R: @chamikaramj for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @pabloem for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @kennknowles @pabloem

@apache apache deleted a comment from github-actions bot Sep 27, 2022
@pabloem
Copy link
Member

pabloem commented Sep 30, 2022

I'm so sorry about the delay @Naireen ! should we get this fixed and ready to go?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

Reminder, please take a look at this pr: @kennknowles @pabloem

@github-actions
Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @apilloud for label java.
R: @johnjcasey for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@johnjcasey
Copy link
Contributor

r: @pabloem as he has started on the review here

@pabloem
Copy link
Member

pabloem commented Oct 17, 2022

@Naireen - what should we do about this PR?

@pabloem pabloem closed this Oct 17, 2022
@pabloem
Copy link
Member

pabloem commented Oct 17, 2022

I chatted with the author. She wants to have it closed, so we'll do that.

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants