Skip to content

Comments

[BEAM-1328] DataflowRunner: Send WindowingStrategy as proto#2340

Closed
kennknowles wants to merge 1 commit intoapache:masterfrom
kennknowles:ship-WindowingStrategy
Closed

[BEAM-1328] DataflowRunner: Send WindowingStrategy as proto#2340
kennknowles wants to merge 1 commit intoapache:masterfrom
kennknowles:ship-WindowingStrategy

Conversation

@kennknowles
Copy link
Member

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@kennknowles
Copy link
Member Author

R: @dhalperi I think you have some context on this. About to run the ValidatesRunner suite.

@kennknowles
Copy link
Member Author

Run Dataflow RunnableOnService

@asfbot
Copy link

asfbot commented Mar 27, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8840/

Build result: FAILURE

[...truncated 720.29 KB...] at hudson.remoting.UserRequest.perform(UserRequest.java:153) at hudson.remoting.UserRequest.perform(UserRequest.java:50) at hudson.remoting.Request$2.run(Request.java:336) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745)Caused by: org.apache.maven.plugin.MojoExecutionException: Dependency problems found at org.apache.maven.plugins.dependency.analyze.AbstractAnalyzeMojo.execute(AbstractAnalyzeMojo.java:261) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) ... 31 more2017-03-27T22:19:34.271 [ERROR] 2017-03-27T22:19:34.271 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-03-27T22:19:34.271 [ERROR] 2017-03-27T22:19:34.271 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-03-27T22:19:34.271 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException2017-03-27T22:19:34.271 [ERROR] 2017-03-27T22:19:34.271 [ERROR] After correcting the problems, you can resume the build with the command2017-03-27T22:19:34.271 [ERROR] mvn -rf :beam-runners-google-cloud-dataflow-javachannel stoppedSetting status of 8f77b5e to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8840/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install
--none--

@kennknowles kennknowles force-pushed the ship-WindowingStrategy branch from 8f77b5e to 2474ac6 Compare March 27, 2017 22:30
@kennknowles
Copy link
Member Author

Run Dataflow RunnableOnService

@kennknowles
Copy link
Member Author

Fixed deps and pushed. I'll check it again later.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0003%) to 70.126% when pulling 2474ac6 on kennknowles:ship-WindowingStrategy into 07274bb on apache:master.

@dhalperi
Copy link
Contributor

Weird -- those tests are looking for a function that only exists in proto 3.2.0, but I am pretty sure we only use proto 3.1.0. Looking around a bit, asynchronously -- feel free to investigate on your own.

@dhalperi
Copy link
Contributor

I lied, the function has been there since 3.0.0: protocolbuffers/protobuf@9086d96

hmmmm

@asfbot
Copy link

asfbot commented Mar 28, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PostCommit_Java_RunnableOnService_Dataflow/2660/

Failed Tests: 209

beam_PostCommit_Java_RunnableOnService_Dataflow/org.apache.beam:beam-runners-google-cloud-dataflow-java: 209


--none--

@kennknowles
Copy link
Member Author

Curious circumstance - it compiles, but has a runtime error at construction time. I suspect something to do with the examples' configuration. Checking.

@kennknowles
Copy link
Member Author

I haven't dealt with proto library pain so much yet, but I do see that we've got protobuf-lite 3.0.1, protobuf-java-3.1.0, and protobuf-utils-3.0.0, and a mesos shaded-protobuf-0.21.1 (hopefully actually relocated) on the runtime classpath. I am guessing these are not pairwise disjoint libraries.

@asfbot
Copy link

asfbot commented Mar 28, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PostCommit_Java_RunnableOnService_Dataflow/2661/

Failed Tests: 209

beam_PostCommit_Java_RunnableOnService_Dataflow/org.apache.beam:beam-runners-google-cloud-dataflow-java: 209


--none--

@davorbonaci
Copy link
Member

Looks obsolete. Close?

@kennknowles
Copy link
Member Author

Yup, looks like it was duped to #2495

@kennknowles kennknowles deleted the ship-WindowingStrategy branch May 26, 2017 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants