[BEAM-115] Represent a Pipeline via a list of Top-level Transforms#2505
[BEAM-115] Represent a Pipeline via a list of Top-level Transforms#2505tgroh wants to merge 2 commits intoapache:masterfrom
Conversation
The root node is a synthetic transform which does not appear within the graph, as it never has any components of note. Instead of referring to a single "root node" in the Pipeline message, refer to the top-level nodes which do not have an enclosing PTransform.
|
R: @kennknowles |
|
Seems reasonable to me. Is there any particular roadblock that prompted it? (I may have missed some dev list discussion or PR commentary) |
|
Converting a Pipeline is close, but the Components (as I've built them) go through the |
|
Refer to this link for build results (access rights to CI server needed): |
|
LGTM |
|
Refer to this link for build results (access rights to CI server needed): Build result: ABORTED[...truncated 2.72 MB...]2017-04-12T19:23:12.674 [INFO] Apache Beam :: SDKs :: Java :: Java 8 Tests ........ SUCCESS [ 17.935 s]2017-04-12T19:23:12.674 [INFO] Apache Beam :: SDKs :: Python ...................... SUCCESS [12:25 min]2017-04-12T19:23:12.674 [INFO] Apache Beam :: Runners :: Flink .................... SUCCESS [ 31.356 s]2017-04-12T19:23:12.674 [INFO] Apache Beam :: Runners :: Flink :: Core ............ SUCCESS [01:47 min]2017-04-12T19:23:12.674 [INFO] Apache Beam :: Runners :: Flink :: Examples ........ SUCCESS [01:28 min]2017-04-12T19:23:12.674 [INFO] Apache Beam :: Runners :: Apex ..................... SUCCESS [01:55 min]2017-04-12T19:23:12.674 [INFO] Apache Beam :: Examples ............................ SUCCESS [ 23.082 s]2017-04-12T19:23:12.674 [INFO] Apache Beam :: Examples :: Java .................... SUCCESS [16:52 min]2017-04-12T19:23:12.674 [INFO] Apache Beam :: Examples :: Java 8 .................. SUCCESS [ 47.890 s]2017-04-12T19:23:12.674 [INFO] Apache Beam :: SDKs :: Java :: Aggregated Javadoc .. SUCCESS [01:27 min]2017-04-12T19:23:12.674 [INFO] ------------------------------------------------------------------------2017-04-12T19:23:12.674 [INFO] BUILD SUCCESS2017-04-12T19:23:12.674 [INFO] ------------------------------------------------------------------------2017-04-12T19:23:12.675 [INFO] Total time: 01:24 h2017-04-12T19:23:12.675 [INFO] Finished at: 2017-04-12T19:23:12+00:002017-04-12T19:23:14.018 [INFO] Final Memory: 284M/2101M2017-04-12T19:23:14.019 [INFO] ------------------------------------------------------------------------Waiting for Jenkins to finish collecting dataBuild timed out (after 100 minutes). Marking the build as aborted.AbortedBuild was abortedchannel stoppedSetting status of cf6946f to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/9458/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install--none-- |
|
retest this please |
|
Refer to this link for build results (access rights to CI server needed): Failed Tests: 1beam_PreCommit_Java_MavenInstall/org.apache.beam:beam-sdks-java-io-hbase: 1--none-- |
|
retest this please |
|
Refer to this link for build results (access rights to CI server needed): |
|
I actually prefer the pipeline having a single root note. Semantically (especially now that we're removing pipeline options) it's cleaner if As for being "empty" it would contain parts and the pipeline-level display_data. If we decide to attach other information to PTransforms (such as resource requirements) that would naturally live there as well. |
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
The root node is a synthetic transform which does not appear within the
graph, as it never has any components of note. Instead of referring to a
single "root node" in the Pipeline message, refer to the top-level nodes
which do not have an enclosing PTransform.