Skip to content

[BEAM-1641] Use processing time for synchronized processing time in Flink runner#2826

Merged
asfgit merged 1 commit intoapache:masterfrom
kennknowles:Flink-sync-proc
May 2, 2017
Merged

[BEAM-1641] Use processing time for synchronized processing time in Flink runner#2826
asfgit merged 1 commit intoapache:masterfrom
kennknowles:Flink-sync-proc

Conversation

@kennknowles
Copy link
Member

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

There are some esoteric expectations that this might violate, like exactly one hourly downstream output aligned to an hour, versus a cfewuple, but we should rephrase docs to remove those expectations IMO.

R: @aljoscha @JingsongLi

@aljoscha
Copy link
Contributor

aljoscha commented May 2, 2017

Run Flink ValidatesRunner

@aljoscha
Copy link
Contributor

aljoscha commented May 2, 2017

LGTM! once Jenkins is green

Thanks for fixing this, @kennknowles! 👍

@kennknowles
Copy link
Member Author

Worker beam6 has been unhappy for a while. Since this affect only Flink and the ValidatesRunner passed, I will also run the thorough verify manually I guess.

@kennknowles
Copy link
Member Author

retest this please

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 69.856% when pulling 05722ac on kennknowles:Flink-sync-proc into ae72456 on apache:master.

@asfgit asfgit merged commit 05722ac into apache:master May 2, 2017
asfgit pushed a commit that referenced this pull request May 2, 2017
@kennknowles kennknowles deleted the Flink-sync-proc branch May 26, 2017 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants