[BEAM-775] Full removal of Aggregators in Java SDK and Runners #2838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabloem
force-pushed
the
full-remove-agg
branch
3 times, most recently
from
a9710b6 to
da85133
Compare
|
Changes Unknown when pulling 6bf4ab7 on pabloem:full-remove-agg into ** on apache:master**. |
Member
Author
|
r: @dhalperi all tests pass. The only thing that is left about aggregators is the class itself. It's not being used anywhere, and it should be removable after the dataflow worker is rebuilt. |
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.