[BEAM-818,BEAM-828] Make tempLocation an inaccessible ValueProvider#2847
Closed
kennknowles wants to merge 1 commit intoapache:masterfrom
Closed
[BEAM-818,BEAM-828] Make tempLocation an inaccessible ValueProvider#2847kennknowles wants to merge 1 commit intoapache:masterfrom
kennknowles wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
Closed
4 tasks
ebfb87a to
b970b22
Compare
Member
Author
|
I think I am going to close this, based on this logic:
I picked up this work sort of out of nowhere and didn't glean this context from my readings. Now I think my approach is not just a hack, but entirely wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify.<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
This is my first foray into
ValueProviderandPipelineOptionsexcitement. The goal: allow users to access thetempLocationthat they specify but make it inaccessible toPTransform.expand(..)implementations.The natural way to do this would be to clone and alter the pipeline options, something that runners also ought to be doing when they tweak them like
TestDataflowRunnerdoes. I am informed this is not possible or feasible in a short timeframe.So this is a hack that might not actually work that lets
get()succeed but makesisAccessible()false. Throwing it out there as a strawman as I don't see a way to do this correctly given today's constraints.Once an approach is decided upon, I will propagate as needed, to e.g.
gcpTempLocation.