Skip to content

[BEAM-1871] Move GCP specific serialization CloudObject and supporting translation code to Dataflow runner module#2862

Closed
lukecwik wants to merge 1 commit intoapache:masterfrom
lukecwik:thin_sdk_core
Closed

[BEAM-1871] Move GCP specific serialization CloudObject and supporting translation code to Dataflow runner module#2862
lukecwik wants to merge 1 commit intoapache:masterfrom
lukecwik:thin_sdk_core

Conversation

@lukecwik
Copy link
Member

@lukecwik lukecwik commented May 3, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify.
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

…g translation code to Dataflow runner module
@lukecwik
Copy link
Member Author

lukecwik commented May 3, 2017

R: @dhalperi @kennknowles

@lukecwik
Copy link
Member Author

lukecwik commented May 3, 2017

Run Dataflow ValidatesRunner

@dhalperi
Copy link
Contributor

dhalperi commented May 3, 2017

Confirming: This is taking code that only DataflowRunner uses and either moving it into Dataflow module or deleted it entirely. Looks awesome to me!

@lukecwik
Copy link
Member Author

lukecwik commented May 3, 2017

@dhalperi That is correct.

@kennknowles
Copy link
Member

So much deletion. So happy.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 70.581% when pulling c85b29f on lukecwik:thin_sdk_core into f33039b on apache:master.

@lukecwik
Copy link
Member Author

lukecwik commented May 3, 2017

The build succeeded https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/10664 but reported failure to Jenkins because it was married with a build in 10665 which seems unrelated.

@lukecwik
Copy link
Member Author

lukecwik commented May 3, 2017

retest this please

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 70.581% when pulling c85b29f on lukecwik:thin_sdk_core into f33039b on apache:master.

@asfgit asfgit closed this in aafa1bb May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants