[BEAM-1871] Move GCP specific serialization CloudObject and supporting translation code to Dataflow runner module#2862
Closed
lukecwik wants to merge 1 commit intoapache:masterfrom
Closed
[BEAM-1871] Move GCP specific serialization CloudObject and supporting translation code to Dataflow runner module#2862lukecwik wants to merge 1 commit intoapache:masterfrom
lukecwik wants to merge 1 commit intoapache:masterfrom
Conversation
…g translation code to Dataflow runner module
Member
Author
Member
Author
|
Run Dataflow ValidatesRunner |
Contributor
|
Confirming: This is taking code that only DataflowRunner uses and either moving it into Dataflow module or deleted it entirely. Looks awesome to me! |
tgroh
approved these changes
May 3, 2017
Member
Author
|
@dhalperi That is correct. |
Member
|
So much deletion. So happy. |
Member
Author
|
The build succeeded https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/10664 but reported failure to Jenkins because it was married with a build in 10665 which seems unrelated. |
Member
Author
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify.<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.