Skip to content

[BEAM-2021] Convert Coder into an Abstract Static Class#2914

Closed
tgroh wants to merge 2 commits intoapache:masterfrom
tgroh:coder_abstract_class
Closed

[BEAM-2021] Convert Coder into an Abstract Static Class#2914
tgroh wants to merge 2 commits intoapache:masterfrom
tgroh:coder_abstract_class

Conversation

@tgroh
Copy link
Member

@tgroh tgroh commented May 5, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify.
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@tgroh
Copy link
Member Author

tgroh commented May 5, 2017

R: @kennknowles @dhalperi

Should be API compatible for all users who do not implement Coder directly, which should be a very small amount.

It is worth considering also making the constructor for Coder package-private and directing users to implement (Structured/Atomic/Custom)Coder

This is the minimal backwards-incompatible change for #2829 that will require a worker dance.

@tgroh tgroh force-pushed the coder_abstract_class branch from 518335c to 858bc42 Compare May 5, 2017 16:22
@dhalperi
Copy link
Contributor

dhalperi commented May 5, 2017

This LGTM

@tgroh tgroh force-pushed the coder_abstract_class branch from 858bc42 to 32dcf3d Compare May 5, 2017 16:32
@tgroh
Copy link
Member Author

tgroh commented May 5, 2017

Had to also update the CoderFactories to be able to resolve the parent Coder type.

@dhalperi
Copy link
Contributor

dhalperi commented May 5, 2017

Still LGTM

@tgroh
Copy link
Member Author

tgroh commented May 5, 2017

Updated worker version for new worker that is compatible.

@asfgit asfgit closed this in 69846f5 May 5, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 70.495% when pulling f4fa283 on tgroh:coder_abstract_class into 3bffe0e on apache:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 70.505% when pulling f4fa283 on tgroh:coder_abstract_class into 3bffe0e on apache:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants