[BEAM-2021] Convert Coder into an Abstract Static Class#2914
Closed
tgroh wants to merge 2 commits intoapache:masterfrom
Closed
[BEAM-2021] Convert Coder into an Abstract Static Class#2914tgroh wants to merge 2 commits intoapache:masterfrom
tgroh wants to merge 2 commits intoapache:masterfrom
Conversation
Member
Author
|
Should be API compatible for all users who do not implement Coder directly, which should be a very small amount. It is worth considering also making the constructor for This is the minimal backwards-incompatible change for #2829 that will require a worker dance. |
518335c to
858bc42
Compare
Contributor
|
This LGTM |
858bc42 to
32dcf3d
Compare
Member
Author
|
Had to also update the CoderFactories to be able to resolve the parent Coder type. |
Contributor
|
Still LGTM |
Member
Author
|
Updated worker version for new worker that is compatible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify.<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.