[BEAM-2166] Mark coders using context as experimental.#2924
Closed
robertwb wants to merge 10 commits into
Closed
Conversation
find . -type f -name '*.java' | xargs sed -i '' 's/\([a-zA-Z]*[bB]yteSize[a-zA-Z]*[(].*\), [^,]*[Cc]ontext[^,()]*\([(][)]\)*[)]/\1)/' Plus a one-off Python script.
find . -type f -name '*.java' | xargs sed -i '' 's/\([.]..code[(].*\), context.nested..[)]/\1)/'
find . -type f -name '*.java' | xargs sed -i '' 's/\([.]..code[(].*\), nestedContext[)]/\1)/'
find . -type f -name '*.java' | xargs sed -i '' 's/\([.]..code[(].*\), Context.NESTED[)]/\1)/'
find . -type f -name '*.java' | xargs sed -i '' 's/\([.]..code[(].*\), Coder.Context.NESTED[)]/\1)/'
Also ran
find . -type f -name '*.java' | xargs sed -i '' 's/Coder.Context/ContextSensitiveCoder.Context/g'
Contributor
Author
|
R: @kennknowles |
Contributor
Author
|
I just saw that Coder was made into an abstract class, which could obviate the need for an intermediate ContextSensitiveCoder class (and make it possible to adapt existing coders gradually over time, possibly post-stable-release if the APIs are appropriately marked). Let me know what you think. |
Contributor
Author
Member
|
FWIW we made it an abstract class explicitly to make it easier to adapt. All the usual reasons. |
Contributor
Author
|
See #2930 instead. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify.<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.