[BEAM-1871] [BEAM-1019 ] Shade dependencies in sdks/core#2996
Closed
vikkyrk wants to merge 2 commits intoapache:release-2.0.0from
vikkyrk:shade_2.0.0
Closed
[BEAM-1871] [BEAM-1019 ] Shade dependencies in sdks/core#2996vikkyrk wants to merge 2 commits intoapache:release-2.0.0from vikkyrk:shade_2.0.0
vikkyrk wants to merge 2 commits intoapache:release-2.0.0from
vikkyrk:shade_2.0.0
Conversation
Contributor
Author
|
R: @davorbonaci @kennknowles |
Member
|
This uncovered many issues with Skipping unloadable classes isn't great, because we might have botched something, but it works around these problems. Perhaps you could narrow the catch block to class not found errors and add a TODO with a link to BEAM-2231? |
davorbonaci
approved these changes
May 9, 2017
Member
davorbonaci
left a comment
davorbonaci
left a comment
There was a problem hiding this comment.
LGTM, modulo @kennknowles' comments
Contributor
Author
|
Done |
Member
|
Merged. Please close. |
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify.<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
com.google.guava:guava,com.google.protobuf:protobuf-java,net.bytebuddy:byte-buddy,org.apache.commons:*net.bytebuddyfails theGcpApiSurfaceTestwithNoClassDefFoundErrorfororg/apache/beam/sdk/repackaged/net/bytebuddy/jar/asm/tree/MethodNode. Looks like an issue with hownet.bytebuddydoes shading fororg.objectweb.asm. Either way theApiSurfaceTestshould be fixed to be able to prune and load classes lazily. For release-2.0.0 we catch and ignore any class loading errors.