Skip to content

Conversation

@svetakvsundhar
Copy link
Contributor

This PR does the following:

  1. Fixes a failing integration test for Dicom IO (Java post-commit broken by DicomIOReadIT #20644), so that we no longer need to ignore the test.
  2. Adds the failing case of the PTransform as an integration test, in addition to a unit test.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@svetakvsundhar
Copy link
Contributor Author

Run Java_Examples_Dataflow PreCommit

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @Abacn for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@svetakvsundhar
Copy link
Contributor Author

R: @Abacn

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@svetakvsundhar svetakvsundhar requested a review from Abacn January 23, 2024 17:05
@Abacn Abacn merged commit cffeff7 into apache:master Jan 23, 2024
@svetakvsundhar svetakvsundhar deleted the dicom_it branch January 23, 2024 19:05
@Abacn
Copy link
Contributor

Abacn commented Jan 24, 2024

Tests still fail on Dataflow PostCommit: https://github.com/apache/beam/actions/runs/7638162210

@Abacn Abacn mentioned this pull request Jan 24, 2024
3 tasks
@svetakvsundhar
Copy link
Contributor Author

Fix PR: #30103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants