Improve Pruning performed by the DirectRunnerApiSurfaceTest#3019
Closed
tgroh wants to merge 1 commit intoapache:masterfrom
Closed
Improve Pruning performed by the DirectRunnerApiSurfaceTest#3019tgroh wants to merge 1 commit intoapache:masterfrom
tgroh wants to merge 1 commit intoapache:masterfrom
Conversation
Prune the parts of the Core SDK that must be exposed as part of the API surface. The remainder should not be exposed accidentally.
|
Changes Unknown when pulling d73ecf4 on tgroh:prune_drapi into ** on apache:master**. |
Member
Author
|
R: @kennknowles |
kennknowles
reviewed
May 15, 2017
| ApiSurface.ofPackage(thisPackage, thisClassLoader) | ||
| // Do not include dependencies that are required based on the known exposures. This | ||
| // could alternatively prune everything exposed by the public parts of the Core SDK | ||
| .pruningClass(Pipeline.class) |
Member
There was a problem hiding this comment.
This seems OK, though org.apache.beam.sdk is already allowed so it should be made automatic. Perhaps this is part of BEAM-2231, making is lazy. Whenever you arrive at a class that is allowed, it should be presumed anything reachable from there is also allowed. Of course, this would make us miss when one of our dependencies mistakenly exposes Guava, for example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify.<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
Prune the parts of the Core SDK that must be exposed as part of the API
surface. The remainder should not be exposed accidentally.