[BEAM-1340] Mark PValue and PValueBase Internal#3033
Closed
tgroh wants to merge 2 commits intoapache:masterfrom
Closed
[BEAM-1340] Mark PValue and PValueBase Internal#3033tgroh wants to merge 2 commits intoapache:masterfrom
tgroh wants to merge 2 commits intoapache:masterfrom
Conversation
These should not be referred to as their abstract types by users, and PipelineRunners won't interact with PValues that aren't PCollections or PCollectionViews.
Member
Author
|
R: @kennknowles |
kennknowles
approved these changes
May 10, 2017
Member
kennknowles
left a comment
kennknowles
left a comment
There was a problem hiding this comment.
LGTM with totally optional nits. Definitely get this into the release.
| * The interface for values that can be input to and output from {@link PTransform PTransforms}. | ||
| * <b><i>For internal use. No backwards compatibility guarantees.</i></b> | ||
| * | ||
| * <p>The interface for primitive values that can be input to and output from |
Member
There was a problem hiding this comment.
Since this paragraph is tautological and the next is about backwards compat (for which there is none), consider deleting them. Anyone who doesn't "already know" what PValue is for should not be touching it.
Member
Author
There was a problem hiding this comment.
Done. Replaced with a terse description ("A primitive within Beam")
| * A {@link PValueBase} is an abstract base class that provides | ||
| * <b><i>For internal use. No backwards compatibility guarantees.</i></b> | ||
| * | ||
| * <p>A {@link PValueBase} is an abstract base class that provides |
Member
There was a problem hiding this comment.
FWIW I don't think we need "sensible defaults" for an non-user-facing interface with one implementation. But no need to mess with that now, obvs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify.<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
These should not be referred to as their abstract types by users, and
PipelineRunners won't interact with PValues that aren't PCollections or
PCollectionViews.