Skip to content

[BEAM-659] Cherry-pick #2985, WindowFn error message improvement, to release-2.0.0#3038

Closed
kennknowles wants to merge 1 commit intoapache:release-2.0.0from
kennknowles:windowfn-cherrypick
Closed

[BEAM-659] Cherry-pick #2985, WindowFn error message improvement, to release-2.0.0#3038
kennknowles wants to merge 1 commit intoapache:release-2.0.0from
kennknowles:windowfn-cherrypick

Conversation

@kennknowles
Copy link
Member

@kennknowles kennknowles commented May 10, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify.
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

This cherry-picks #2985 which adjusts the API for WindowFn to allow providing a meaningful error message to users.

@kennknowles
Copy link
Member Author

run flink validatesrunner

@kennknowles
Copy link
Member Author

(just checking that there is no neglected ValidatesRunner test that this affects - the precommit is known to be good)

@kennknowles
Copy link
Member Author

Even though precommit ran out of time in the Dataflow examples, the examples because with only 2 minutes left on the clock. I don't think this was caused by that, but by overall build time growth. I have also confirmed that there is not even a compile time incompatibility here, so a runtime incompatibility is extremely unlikely.

I'll note that the Flink ValidatesRunner passed for simple coverage, then I'll rebase and kick precommit and
Dataflow ValidatesRunner for added signal there.

@kennknowles kennknowles force-pushed the windowfn-cherrypick branch from 3ab5dfc to 5a49d10 Compare May 10, 2017 16:43
@kennknowles
Copy link
Member Author

run dataflow validatesrunner

@kennknowles
Copy link
Member Author

I think that unfortunately the impact of this is not sufficient to make a backwards incompatible change right now. We'll do it in a compatible way.

@kennknowles kennknowles deleted the windowfn-cherrypick branch May 26, 2017 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants