Change type for UnboundedReaderMaxReadTimeSec #31037
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
CC: @kennknowles |
| void setReaderCacheTimeoutSec(Integer value); | ||
|
|
||
| /** The max amount of time an UnboundedReader is consumed before checkpointing. */ | ||
| @Description( |
There was a problem hiding this comment.
Mentioning that the representation can be in fractions of seconds is probably a good call-out here
There was a problem hiding this comment.
Good point. added additional comment.
| new Duration(beforeReading, afterReading).getStandardSeconds(), | ||
| lessThanOrEqualTo(maxReadSec + 1)); | ||
| new Duration(beforeReading, afterReading).getMillis(), | ||
| lessThanOrEqualTo((long) (maxReadSec * 1000L))); |
There was a problem hiding this comment.
I think you're short a second on this comparison looking at the old unit test, although I do not know if the increased resolution to milliseconds renders the +1 second useless or not
There was a problem hiding this comment.
good catch. fixed.
This reverts commit bb310e7.
2 participants
UnboundedReader is controlled with UnboundedReaderMaxReadTimeSec and UnboundedReaderMaxElements.
For sub second latency user has to set UnboundedReaderMaxElements to 1 which is not flexible as there may be multiple situation where there are more elements.
In this change UnboundedReaderMaxReadTimeSec becomes double. Change is backward compatible.
Unlike #31036, this doesn't introduce additional flag.