Skip to content

Conversation

@celeste-zeng
Copy link
Contributor

#31490 plumbs Redistribute "allow_duplicates" property to Dataflow.

Reason to cherry-pick:

With release-2.57.0, Dataflow customers can use per-stage checkpointless shuffle (which allows duplicated elements in the output) by using the Redistribute transform, rather than having to enable checkpointless shuffle mode for the entire pipeline through an experiment.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

)

 - Since Dataflow only translates primitives, added a runner-specific DataflowGroupByKey primitive
 - Added override for RedistributeByKey that replaces GBK with Dataflow GBK, to plumb property
Copy link
Member

@kennknowles kennknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will merge when green

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@celeste-zeng
Copy link
Contributor Author

Checked failure details and all the test failed with the following error:

java.lang.RuntimeException: Startup of the worker pool in zone us-central1-c failed to bring up any of the desired 1 workers. Please refer to https://cloud.google.com/dataflow/docs/guides/common-errors#worker-pool-failure for help troubleshooting. QUOTA_EXCEEDED: Instance 'viewtest0testcombinedmaps-06171609-8ekx-harness-cg5n' creation failed: Quota 'IN_USE_ADDRESSES' exceeded.  Limit: 1200.0 in region us-central1.Workflow failed.
    at org.apache.beam.runners.dataflow.TestDataflowRunner.run(TestDataflowRunner.java:149)
    at org.apache.beam.runners.dataflow.TestDataflowRunner.run(TestDataflowRunner.java:101)
    at org.apache.beam.runners.dataflow.TestDataflowRunner.run(TestDataflowRunner.java:56)
    at org.apache.beam.sdk.Pipeline.run(Pipeline.java:325)
    at org.apache.beam.sdk.testing.TestPipeline.run(TestPipeline.java:404)
    at org.apache.beam.sdk.testing.TestPipeline.run(TestPipeline.java:343)
    at org.apache.beam.sdk.transforms.ViewTest.testCombinedMapSideInput(ViewTest.java:1632)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
    at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
    at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
    at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
    at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288)
    at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.lang.Thread.run(Thread.java:750)

Looks like a resource exhausted issue in the testing project so it is likely not related to the changes here. Also, the failed checks passed before in the original PR #31490.

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@kennknowles kennknowles merged commit 96766f2 into apache:release-2.57.0 Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants