-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Replace StateTag.StateBinder to top level StateBinder in SparkStateInternals #31798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace StateTag.StateBinder to top level StateBinder in SparkStateInternals #31798
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @shunping added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Reminder, please take a look at this pr: @shunping |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @shunping added as fallback since no labels match configuration Available commands:
|
|
LGTM but probably worth touching some validates runner files in |
Thank you for comment. I'll touch trigger_files and validate Spark Runner! 😊 |
|
Reminder, please take a look at this pr: @shunping |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @shunping added as fallback since no labels match configuration Available commands:
|
|
@kennknowles |
Please add a meaningful description for your change here
fixes #31797
This PR contains theses changes
StateTag.StateBinderto top levelStateBinderinSparkStateInternalsStateTag.StateBinderdoc for link top levelStateBinder(org.apache.beam.sdk.state.StateBinder)Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.