Skip to content

Move snappy-java version to dependencyManagement#3185

Merged
asfgit merged 1 commit into
apache:masterfrom
kennknowles:snappy-version
May 22, 2017
Merged

Move snappy-java version to dependencyManagement#3185
asfgit merged 1 commit into
apache:masterfrom
kennknowles:snappy-version

Conversation

@kennknowles
Copy link
Copy Markdown
Member

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify.
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

R: @dhalperi peeled off this trivial bit from my more quixotic shading PR. I believe you had commented on this at one point.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.01%) to 70.657% when pulling c7bd2b4 on kennknowles:snappy-version into ce00d24 on apache:master.

Copy link
Copy Markdown
Member

@lukecwik lukecwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R: @lukecwik

LGTM

@asfgit asfgit merged commit c7bd2b4 into apache:master May 22, 2017
@kennknowles kennknowles deleted the snappy-version branch May 26, 2017 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants