[BEAM-2333] Remove Pipeline reference from TransformHierarchy#3187
Merged
asfgit merged 1 commit intoapache:masterfrom May 22, 2017
Merged
[BEAM-2333] Remove Pipeline reference from TransformHierarchy#3187asfgit merged 1 commit intoapache:masterfrom
asfgit merged 1 commit intoapache:masterfrom
Conversation
kennknowles
force-pushed
the
TransformHierarchy
branch
from
481f418 to
2e063a1
Compare
tgroh
reviewed
May 19, 2017
| * Called before visiting anything values or transforms, as many uses of a visitor require | ||
| * access to the {@link Pipeline} object itself. | ||
| */ | ||
| void visitPipeline(Pipeline p); |
Member
There was a problem hiding this comment.
Perhaps this can be enterPipeline/exitPipeline, and we can get rid of the root node (and bring the TransformHierarchy in line with the runner API Pipeline definition)
kennknowles
force-pushed
the
TransformHierarchy
branch
from
2e063a1 to
218d090
Compare
kennknowles
force-pushed
the
TransformHierarchy
branch
3 times, most recently
from
b01fbba to
71ace1c
Compare
This change removes a direct dependency cycle between Pipeline and TransformHierarchy. There is still an indirect cycle through PValues, but that is slightly less problematic.
kennknowles
force-pushed
the
TransformHierarchy
branch
from
71ace1c to
5e9fceb
Compare
Member
Author
|
retest this please |
tgroh
approved these changes
May 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes a direct dependency cycle between Pipeline and
TransformHierarchy. There is still an indirect cycle through PValues, but that
is slightly less problematic.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify.<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
R: @tgroh