Extract the Main Input PCollection in ParDos#3190
Closed
tgroh wants to merge 4 commits intoapache:masterfrom
Closed
Extract the Main Input PCollection in ParDos#3190tgroh wants to merge 4 commits intoapache:masterfrom
tgroh wants to merge 4 commits intoapache:masterfrom
Conversation
Member
Author
|
R: @kennknowles |
tgroh
force-pushed
the
par_dos_get_main_input
branch
from
107693c to
6698929
Compare
kennknowles
reviewed
May 19, 2017
| ptransform.getSpec().getUrn()); | ||
| ParDoPayload payload = ptransform.getSpec().getParameter().unpack(ParDoPayload.class); | ||
| String mainInputId = null; | ||
| for (Map.Entry<String, String> input : ptransform.getInputsMap().entrySet()) { |
Member
There was a problem hiding this comment.
ptransform.getInputsMap().keys().removeAll(payload.getSideInputsMap().keys()?
kennknowles
reviewed
May 20, 2017
| return doFnAndMainOutputTagFromProto(payload.getDoFn()).getMainOutputTag(); | ||
| } | ||
|
|
||
| public static RunnerApi.PCollection getMainInput( |
Member
There was a problem hiding this comment.
This seems unused except in test. Have I missed something?
Should javadoc the requirement that it is a ParDo, or just decompose the input outside the method, and perhaps also make it private.
Member
Author
There was a problem hiding this comment.
This is going to be used within the Dataflow Worker
Member
|
You know, I think I just reviewed one commit. Give me a second. |
Member
|
Yea the other commit is just fine. Great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify.<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.