[BEAM-1928] Add CombineTranslator#3199
Merged
asfgit merged 1 commit intoapache:masterfrom May 25, 2017
Merged
Conversation
Member
Author
|
R: @kennknowles |
tgroh
force-pushed
the
combine_translator
branch
2 times, most recently
from
96b7878 to
e898fdb
Compare
kennknowles
reviewed
May 23, 2017
| public static CombinePayload toProto( | ||
| AppliedPTransform<?, ?, Combine.PerKey<?, ?, ?>> combine, SdkComponents sdkComponents) | ||
| throws IOException { | ||
| Coder<?> accumulatorCoder = null; |
Member
There was a problem hiding this comment.
You'll actually need this coder. I added a hack and hit some other snags like unequal CountFn.
Member
Author
There was a problem hiding this comment.
Yeah, there were a few things, they should have been fixed. PTAL
This translates Combines to CombinePayloads and back
Member
Author
|
PTAL |
asfgit
pushed a commit
that referenced
this pull request
May 25, 2017
jkff
added a commit
to jkff/incubator-beam
that referenced
this pull request
May 25, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This translates Combines to CombinePayloads and back
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify.<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.