[BEAM-2345] Make versioning in root pom consistent.

[jasonkuster]

Signed-off-by: Jason Kuster jasonkuster@google.com

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

• Make sure the PR title is formatted like:
  [BEAM-<Jira issue #>] Description of pull request
• Make sure tests pass via mvn clean verify.
• Replace <Jira issue #> in the title with the actual Jira issue
  number, if there is one.
• If this contribution is large, please file an Apache
  Individual Contributor License Agreement.

---

[jasonkuster]

R: @dhalperi

[jasonkuster]

Main question -- should this be applied to maven version as well? I've done so, as you can see on last line (and another in the middle); sound good?

[dhalperi]

I do not think it's feasible to review this as-is. A few suggestions for improvement:

1. Please separate pure reorderings (alphabetization) with no believe semantic change in a separate commit from adding new ones.

2. Please keep plugin versions in a separate section from dependency versions, as in the current scheme.

3. Please ensure things like comments are preserved if you're moving code around -- e.g., the comment about keeping maven versions in sync seems to have been lost.

[davorbonaci]

Any updates?

[jasonkuster]

AIs here:

• Break into two commits at least -- alphabetization in the first, versioning fixes in the second.
• Create different sections for plugin and dependency versions (investigate whether this will be an actual XML separation or just comment blocks).

Dan's comment about the comments is I believe moot here -- the two numbers which had to be kept in sync are now just controlled by one version property, eliminating the possibility of becoming out of sync.

[davorbonaci]

Any updates?

[jasonkuster]

I've broken this into two changes -- alphabetization in the first, versioning fixes in the second. There are now sections for dependency and plugin versions.

PTAL @davorbonaci

[coveralls]

Changes Unknown when pulling 6f82a9c on jasonkuster:root-pom-versions into ** on apache:master**.

[kennknowles]

Looks like this needs rebase

[aaltay]

@jasonkuster Is this PR still needed?

[reuvenlax]

ping

[reuvenlax]

@jasonkuster should we close this?

[aaltay]

What are the next steps for this PR?

[aaltay]

I will close this PR based on the stale PR policy, please reopen if you would like to continue working on it.