[BEAM-2333] Use URN to get RootInputProvider in Java DirectRunner#3217
Closed
kennknowles wants to merge 19 commits intoapache:masterfrom
Closed
[BEAM-2333] Use URN to get RootInputProvider in Java DirectRunner#3217kennknowles wants to merge 19 commits intoapache:masterfrom
kennknowles wants to merge 19 commits intoapache:masterfrom
Conversation
This is to give a standard and obvious suffix for all our helper classes for translating to/from Runner API protos.
This is the type that will be returned when a pipeline is deserialized. This also is convenient for direct runner overrides which do not really merit translator registrations, yet URNs need to be known in order to key the evaluator registry off URN.
Member
Author
|
Ah, it actually appears that #3195 needs this to succeed. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify.<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
This is built on #3195. It adjusts another registry to be agnostic as to whether the transforms are original Java transforms or perhaps not Java at all.
R: @tgroh