Skip to content

Property names cleanup#3265

Closed
jkff wants to merge 2 commits into
apache:masterfrom
jkff:property-names-cleanup
Closed

Property names cleanup#3265
jkff wants to merge 2 commits into
apache:masterfrom
jkff:property-names-cleanup

Conversation

@jkff
Copy link
Copy Markdown
Contributor

@jkff jkff commented May 31, 2017

This also updates Dataflow worker to a version that doesn't depend on PropertyNames which are not used in Dataflow runner itself. So, from now on, if a PropertyNames entry is unused, it can be deleted (but renaming is still not safe).

R: @kennknowles

@jkff
Copy link
Copy Markdown
Contributor Author

jkff commented May 31, 2017

Run Dataflow ValidatesRunner

@asfbot
Copy link
Copy Markdown

asfbot commented May 31, 2017

--none--

@asfbot
Copy link
Copy Markdown

asfbot commented May 31, 2017

Build finished.
--none--

@jkff
Copy link
Copy Markdown
Contributor Author

jkff commented Jun 1, 2017

Ping.

Copy link
Copy Markdown
Member

@kennknowles kennknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfgit asfgit closed this in eee6726 Jun 2, 2017
@jkff jkff deleted the property-names-cleanup branch June 2, 2017 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants