[BEAM-3271] Add CreatePCollectionView translation#3281
Merged
asfgit merged 2 commits intoJun 6, 2017
Conversation
kennknowles
force-pushed
the
CreatePCollectionView-translation
branch
from
8c7933e to
23a55ff
Compare
kennknowles
changed the title
|
Build finished. |
1 similar comment
|
Build finished. |
Contributor
|
retest this please |
|
Build finished. |
4 tasks
kennknowles
force-pushed
the
CreatePCollectionView-translation
branch
from
23a55ff to
989c8ac
Compare
tgroh
approved these changes
Jun 5, 2017
| } | ||
|
|
||
| /** | ||
| * Translates a non-composite {@link AppliedPTransform} into a runner API proto. |
Member
There was a problem hiding this comment.
"An AppliedPTransform with no components"?
Alternatively this could be "Translates an AppliedPTransform into a runner API proto with no component transforms.", and disclaims that this should not be used when translating a Pipeline
kennknowles
force-pushed
the
CreatePCollectionView-translation
branch
from
989c8ac to
c3b036a
Compare
asfgit
pushed a commit
that referenced
this pull request
Jun 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify.<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
R: @tgroh this one is "fun". The deprecated no-longer-a-primitive transform sure needs a payload in order to survive and have its override function correctly.