[BEAM-3271] Add TestStream translation#3283
Merged
Merged
Conversation
4 tasks
tgroh
reviewed
Jun 2, 2017
| @Override | ||
| public RunnerApi.FunctionSpec translate( | ||
| AppliedPTransform<?, ?, TestStream<?>> transform, SdkComponents components) { | ||
| return RunnerApi.FunctionSpec.newBuilder().setUrn(getUrn(transform.getTransform())).build(); |
Member
There was a problem hiding this comment.
This seems like it's missing the payload
Member
Author
There was a problem hiding this comment.
True! Added an additional test going through the registrar.
These are needed for deserialization from proto.
kennknowles
force-pushed
the
TestStream-translation
branch
from
3bf6fc3 to
0cedc61
Compare
tgroh
approved these changes
Jun 2, 2017
| import org.junit.runners.Suite; | ||
|
|
||
| /** Tests for {@link TestStreamTranslation}. */ | ||
| @RunWith(Suite.class) |
Member
There was a problem hiding this comment.
Why do this via suite instead of Parameterized directly? Just future-proofing?
Member
Author
There was a problem hiding this comment.
Somehow a top-level Parameterized bothers me. Two test methods sharing a set of parameters to exhaustively loop over is a pretty special case so I didn't naturally make it the default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify.<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
R: @tgroh
Because this is a real primitive, I added a somewhat comprehensive payload and tested it a bit.