Increase Go test coverage run timeout to 25 minutes#33223
Increase Go test coverage run timeout to 25 minutes#33223kennknowles merged 1 commit intoapache:masterfrom
Conversation
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
.github/workflows/go_tests.yml
Outdated
| - name: Delete old coverage | ||
| run: "cd sdks && rm -rf .coverage.txt || :" | ||
| - name: Run coverage | ||
| timeout-minutes: 25 |
There was a problem hiding this comment.
There is no default step timeout, so I don't think this does what you're expecting. I assume the mentioned timeout was for an individual test or the command itself
There was a problem hiding this comment.
The timeout is the default 'go test' timeout, so a flag needs to be added to the go test call down below in the run clause.
-timeout=25m
damccorm
left a comment
damccorm
left a comment
There was a problem hiding this comment.
I don't think we should do this as written, I expect it is only likely to cause more problems
.github/workflows/go_tests.yml
Outdated
| - name: Delete old coverage | ||
| run: "cd sdks && rm -rf .coverage.txt || :" | ||
| - name: Run coverage | ||
| timeout-minutes: 25 |
There was a problem hiding this comment.
The timeout is the default 'go test' timeout, so a flag needs to be added to the go test call down below in the run clause.
-timeout=25m
kennknowles
force-pushed
the
go-coverage-timeout
branch
from
856e92a to
e1b7b3f
Compare
|
PTAL |
3 participants
This may at least partially address #32627. Following the suggestion by @lostluck there.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.