[BEAM-1377] Uses KV in SplittableParDo expansion instead of ElementAndRestriction#3417
Closed
jkff wants to merge 2 commits intoapache:masterfrom
Closed
[BEAM-1377] Uses KV in SplittableParDo expansion instead of ElementAndRestriction#3417jkff wants to merge 2 commits intoapache:masterfrom
jkff wants to merge 2 commits intoapache:masterfrom
Conversation
Member
|
It makes sense to use KV over ElementAndRestriction |
|
Changes Unknown when pulling dae5221 on jkff:sdf-kv into ** on apache:master**. |
|
Changes Unknown when pulling dae5221 on jkff:sdf-kv into ** on apache:master**. |
This is a workaround for the following issue. ElementAndRestriction is in runners-core, which may be shaded by runners (and is shaded by Dataflow runner), hence it should be *both* produced and consumed by workers - but currently it's produced by (shaded) SplittableParDo and consumed by (differently shaded) ProcessFn in the runner's worker code. There are several ways out of this, e.g. moving EAR into the SDK (icky because it's an implementation detail of SplittableParDo), or using a type that's already in the SDK. There may be other more complicated ways too.
Contributor
Author
|
Run Dataflow ValidatesRunner |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a workaround for the following issue.
ElementAndRestriction is in runners-core, which may be shaded by runners
(and is shaded by Dataflow runner), hence it should be both produced
and consumed by workers - but currently it's produced by (shaded)
SplittableParDo and consumed by (differently shaded) ProcessFn in the
runner's worker code.
There are several ways out of this, e.g. moving EAR into the SDK (icky
because it's an implementation detail of SplittableParDo), or using
a type that's already in the SDK. There may be other more complicated
ways too.
(This PR will require building a compatible Dataflow worker, so it will naturally not pass tests initially)
R: @kennknowles