Add WindowFn#assignsToOneWindow#3452
Closed
tgroh wants to merge 1 commit into
Closed
Conversation
Member
Author
|
R: @kennknowles |
kennknowles
reviewed
Jun 27, 2017
| return false; | ||
| } | ||
|
|
||
| /** |
Member
There was a problem hiding this comment.
<p>If it varies per element, or cannot be determined, you should conservatively return false
kennknowles
reviewed
Jun 27, 2017
| expected, | ||
| runWindowFn( | ||
| SlidingWindows.of(new Duration(10)).every(new Duration(5)), | ||
| runWindowFn(windowFn, |
Member
There was a problem hiding this comment.
Geez, this method makes the test unreadable.
Member
Author
There was a problem hiding this comment.
Member
|
And LGTM modulo comment comment. |
tgroh
force-pushed
the
assign_to_one_window_fn
branch
from
8a8ac5b to
660d46c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify.<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.