Skip to content

Disallow Combiner Lifting for multi-window WindowFns#3496

Merged
asfgit merged 1 commit intoapache:masterfrom
tgroh:combine_sliding_windows
Jul 5, 2017
Merged

Disallow Combiner Lifting for multi-window WindowFns#3496
asfgit merged 1 commit intoapache:masterfrom
tgroh:combine_sliding_windows

Conversation

@tgroh
Copy link
Copy Markdown
Member

@tgroh tgroh commented Jul 5, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify.
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@tgroh
Copy link
Copy Markdown
Member Author

tgroh commented Jul 5, 2017

R: @bjchambers @kennknowles

@tgroh
Copy link
Copy Markdown
Member Author

tgroh commented Jul 5, 2017

Run dataflow validatesrunner

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.002%) to 70.84% when pulling 29c2bca on tgroh:combine_sliding_windows into 39c80f6 on apache:master.

@kennknowles
Copy link
Copy Markdown
Member

LGTM. Removes one of the postcommit failures.

@asfgit asfgit merged commit 29c2bca into apache:master Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants