Skip to content

Deflake spark test#35000

Merged
kennknowles merged 3 commits intoapache:masterfrom
Abacn:deflake
May 19, 2025
Merged

Deflake spark test#35000
kennknowles merged 3 commits intoapache:masterfrom
Abacn:deflake

Conversation

@Abacn
Copy link
Contributor

@Abacn Abacn commented May 19, 2025

#34974 was intended to deflake the test. However, there was a debug leftover https://github.com/apache/beam/pull/34974/files#diff-78a108ab469ee9be0d8fae0f18c0c143e04fc24d44f9f78f65b97434fc234890R93 making test not cached and introduced more flakes

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Abacn
Copy link
Contributor Author

Abacn commented May 19, 2025

R: @akashorabek

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Abacn
Copy link
Contributor Author

Abacn commented May 19, 2025

Tests failing on CI but passed locally, likely gradle cache issue

@Abacn
Copy link
Contributor Author

Abacn commented May 19, 2025

java.lang.AssertionError: expected:<78> but was:<111>
	at org.junit.Assert.fail(Assert.java:89)

This suggests recover from checkpoint does not work as expected

@Abacn
Copy link
Contributor Author

Abacn commented May 19, 2025

R: @kennknowles

@kennknowles kennknowles merged commit c279623 into apache:master May 19, 2025
18 checks passed
@Abacn Abacn deleted the deflake branch May 19, 2025 18:50
@twosom
Copy link
Contributor

twosom commented May 20, 2025

@Abacn
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants