Test GBK immediately followed by stateful ParDo#3562
Merged
asfgit merged 1 commit intoapache:masterfrom Jul 14, 2017
Merged
Conversation
bjchambers
approved these changes
Jul 14, 2017
| @Test | ||
| @Category({ValidatesRunner.class, UsesTimersInParDo.class}) | ||
| public void testGbkFollowedByUserTimers() throws Exception { | ||
| final String timerId = "foo"; |
Contributor
There was a problem hiding this comment.
why not make timerId a field of the fn?
kennknowles
force-pushed
the
GBK-then-state
branch
from
acc35e2 to
5d9fe88
Compare
asfgit
pushed a commit
that referenced
this pull request
Jul 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify.<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.