[BEAM-2453] Perform a Multi-step combine in the DirectRunner#3579
Closed
tgroh wants to merge 1 commit into
Closed
Conversation
tgroh
force-pushed
the
combiner_lifting_direct_runner
branch
from
522fa54 to
300d807
Compare
Member
Author
|
R: @kennknowles |
tgroh
force-pushed
the
combiner_lifting_direct_runner
branch
from
300d807 to
d2aa893
Compare
kennknowles
requested changes
Jul 18, 2017
| return new PTransformMatcher() { | ||
| @Override | ||
| public boolean matches(AppliedPTransform<?, ?, ?> application) { | ||
| if (application.getTransform() instanceof Combine.PerKey) { |
Member
There was a problem hiding this comment.
This matcher will not match rehydrated combine after #3334, because no transform will have this class. Instead, I think a CombineTranslation is needed, check the URN here, and all the bits needed by isApplicable should be in the CombinePayload.
| transform.getTransform().getFn().getClass().getName()); | ||
| @SuppressWarnings("unchecked") | ||
| CombineFn<InputT, AccumT, OutputT> fn = | ||
| (CombineFn<InputT, AccumT, OutputT>) transform.getTransform().getFn(); |
Member
There was a problem hiding this comment.
Here, too, the override should be in terms of the bits pulled from CombinePayload. They can be cast to Java UDFs for now, but I think it is only needed at the last moment before you pass to MultiStepCombine.
tgroh
force-pushed
the
combiner_lifting_direct_runner
branch
from
d2aa893 to
e747838
Compare
tgroh
force-pushed
the
combiner_lifting_direct_runner
branch
from
e747838 to
1fa8364
Compare
Member
Author
|
Built on top of #3597, so that should be reviewed first. |
tgroh
force-pushed
the
combiner_lifting_direct_runner
branch
2 times, most recently
from
a183453 to
08093f7
Compare
tgroh
force-pushed
the
combiner_lifting_direct_runner
branch
2 times, most recently
from
b53d7e3 to
22c7efa
Compare
|
Changes Unknown when pulling 22c7efa on tgroh:combiner_lifting_direct_runner into ** on apache:master**. |
tgroh
force-pushed
the
combiner_lifting_direct_runner
branch
2 times, most recently
from
805c9fe to
38c9d1e
Compare
This exercises the entire CombineFn lifecycle for simple combine fns, expressed as a collection of DoFns.
tgroh
force-pushed
the
combiner_lifting_direct_runner
branch
from
38c9d1e to
845ac35
Compare
Member
Author
|
PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify.<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
This exercises the entire CombineFn lifecycle for simple combine fns,
expressed as a collection of DoFns.