#36196: Capture build scans from TypeScript tests - #36197
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @clayburn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces Develocity build scan capabilities for TypeScript test runs within the CI pipeline. The primary goal is to provide deeper insights into the performance, dependencies, and test outcomes of npm-based builds, aligning with the detailed reporting already available for Gradle builds. This enhancement improves debugging and analysis of CI failures and performance bottlenecks in the TypeScript SDK.
Highlights
- Develocity Integration: Integrated Develocity to capture build scan data for npm builds triggered by TypeScript tests in CI, providing enhanced observability similar to existing Gradle build scans.
- Test Reporting Enhancement: Configured
cypress-multi-reportersand a customreporterConfig.jsto enable detailed test reporting, specifically utilizing Develocity's Mocha reporter for comprehensive test insights. - Dependency Management: Updated
package-lock.jsonto reflect the addition ofcypress-multi-reportersand its associated dependencies (lodash,semver), alongside an update to the project's snapshot version.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
db2b0bf to
aa98841
Compare
|
Assigning reviewers: R: @damccorm for label build. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
This enhancement captures build scan data for the npm builds triggered as part of the Typescript Tests workflow in CI. This is similar to the build scans already published by beam's Gradle builds.
Here is an example of what these build scans look like, including:
Fixes #36196
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.