Skip to content

[BEAM-3133] Add logging when Staging takes a long time#3641

Merged
tgroh merged 1 commit intoapache:masterfrom
tgroh:log_during_staging
Nov 28, 2017
Merged

[BEAM-3133] Add logging when Staging takes a long time#3641
tgroh merged 1 commit intoapache:masterfrom
tgroh:log_during_staging

Conversation

@tgroh
Copy link
Member

@tgroh tgroh commented Jul 26, 2017

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 70.506% when pulling c43b2ca on tgroh:log_during_staging into 71196ec on apache:master.

@reuvenlax
Copy link
Contributor

reuvenlax commented Aug 29, 2017

@tgroh any update?

@aaltay
Copy link
Member

aaltay commented Oct 20, 2017

@tgroh Is this PR still relevant?

@tgroh
Copy link
Member Author

tgroh commented Oct 21, 2017

It's very low priority, but I think it's still an improvement.

@reuvenlax
Copy link
Contributor

If we're not going to finish this soon, let's close the PR. We can always reopen the PR later.

@reuvenlax
Copy link
Contributor

Please associate a JIRA issue with this as well.

@tgroh tgroh changed the title Add logging when Staging takes a long time [BEAM-3133] Add logging when Staging takes a long time Nov 1, 2017
@tgroh
Copy link
Member Author

tgroh commented Nov 1, 2017

R: @kennknowles

@tgroh tgroh force-pushed the log_during_staging branch from c43b2ca to d9aa789 Compare November 1, 2017 18:33
@tgroh
Copy link
Member Author

tgroh commented Nov 28, 2017

retest this please

@tgroh tgroh force-pushed the log_during_staging branch from d9aa789 to 649907c Compare November 28, 2017 18:51
@tgroh tgroh merged commit dc3a664 into apache:master Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants