Fix RequestResponseIO parseAndThrow to preserve retryable exception types

[PDGGK]

Summary

Fixes #37176 - RequestResponseIO parseAndThrow wraps retryable exceptions

The parseAndThrow method in Call.java was wrapping retryable exceptions (UserCodeTimeoutException, UserCodeRemoteSystemException) in a generic UserCodeExecutionException, which broke the retry logic that depends on exception.shouldRepeat().

Root Cause

When parseAndThrow caught an ExecutionException, it only checked the direct cause. If the cause was a generic exception wrapping a retryable one, it would throw the generic wrapper, losing the retryable behavior.

Solution

• Use Guava's Throwables.getCausalChain() to traverse the full exception chain
• Preserve all retryable exception types: UserCodeQuotaException, UserCodeTimeoutException, UserCodeRemoteSystemException
• Prefer specific exception types over generic ones to prevent masking
• Handle circular references gracefully

Changes

Modified:

• sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Call.java - Rewrote parseAndThrow method

Added Tests:

• CallTest.java - Added 10 comprehensive tests covering:
  • Direct retryable exceptions
  • Nested exceptions (multiple wrapper layers)
  • Triple-nested exceptions
  • Generic exceptions wrapping retryable ones
  • Circular reference handling
  • Non-UserCode exceptions

Test Results

All tests pass:

• ✅ Existing CallTest suite
• ✅ 10 new tests for exception handling
• ✅ Full rrio module tests
• ✅ Code formatting (spotless)

Test plan

• Unit tests added for all edge cases
• Existing tests continue to pass
• Code formatting verified

🤖 Generated with Claude Code

[gemini-code-assist]

Summary of Changes

Hello @PDGGK, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where retryable exceptions were being incorrectly wrapped by a generic UserCodeExecutionException, thereby breaking the retry mechanism. The core change involves enhancing the exception parsing logic to traverse the full causal chain, ensuring that specific retryable exception types are preserved and re-thrown. This significantly improves the reliability of retry logic within the RequestResponseIO component.

Highlights

• Exception Preservation: The parseAndThrow method in Call.java has been refactored to correctly identify and re-throw specific retryable exceptions (UserCodeQuotaException, UserCodeTimeoutException, UserCodeRemoteSystemException) even when they are deeply nested within other exceptions, preventing them from being generically wrapped by UserCodeExecutionException.
• Causal Chain Traversal: The fix utilizes Guava's Throwables.getCausalChain() to thoroughly inspect the entire exception causal chain, ensuring that the original retryable exception type is not lost due to intermediate wrapping.
• Circular Reference Handling: The updated logic now gracefully handles circular references within an exception's causal chain, preventing infinite loops and throwing a UserCodeExecutionException with a descriptive message in such cases.
• Comprehensive Testing: Ten new unit tests have been added to CallTest.java to cover various scenarios, including direct, nested, and triple-nested retryable exceptions, generic exceptions wrapping retryable ones, non-UserCode exceptions, and circular exception chains, ensuring the robustness of the fix.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Assigning reviewers:

R: @kennknowles for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).