Skip to content

Add Staged Artifact validations for RunnerV2#37974

Open
tarun-google wants to merge 7 commits intoapache:masterfrom
tarun-google:add_expected_sha_checks
Open

Add Staged Artifact validations for RunnerV2#37974
tarun-google wants to merge 7 commits intoapache:masterfrom
tarun-google:add_expected_sha_checks

Conversation

@tarun-google
Copy link
Contributor

@tarun-google tarun-google commented Mar 26, 2026

Adding Staged Artifact validations for RunnerV2. For safety we also introduced 'disable_integrity_checks' allowing users to disable the checks. This flag will be used to guard entire feature. Backend and Worker harness also have access to this flag to make decisions. SDK already uploads these sha during the submission for RunnerV2. So, no need to make any changes in Job Submission

Fixes:

  1. Java and Python staged artifacts validation for RunnerV2
  2. Added the flag for typescript materialize too.
  3. Golang legacy flow get the hash from workerHarness. SDK already does the validations. So, the fix should be from worker. Added the disable flag for safety again.

Next Fix:
Staged pipeline validation.

Test:
Screenshot 2026-03-26 at 8 38 13 AM

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the security and reliability of artifact staging for RunnerV2 by introducing mandatory SHA256 integrity checks. To maintain flexibility, a new experiment flag has been added that allows users to disable these checks if required. The changes span across multiple SDKs and the worker harness to ensure consistent behavior during job execution.

Highlights

  • Staged Artifact Validation: Implemented SHA256 integrity validation for staged artifacts in RunnerV2 across Java, Python, and Go SDKs to ensure artifact consistency.
  • Safety Mechanism: Introduced a 'disable_integrity_checks' experiment flag to allow users to bypass these validations if necessary.
  • Context Injection: Updated container boot processes to inject pipeline options into the context, enabling the worker harness to access the new validation flag.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@tarun-google
Copy link
Contributor Author

R: @Abacn @tvalentyn @kennknowles

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant