Skip to content

[OpenTelemetry] Add gcp otel auth extension#38773

Open
stankiewicz wants to merge 2 commits into
apache:masterfrom
stankiewicz:otel_gcp_auth
Open

[OpenTelemetry] Add gcp otel auth extension#38773
stankiewicz wants to merge 2 commits into
apache:masterfrom
stankiewicz:otel_gcp_auth

Conversation

@stankiewicz
Copy link
Copy Markdown
Contributor

Forks https://github.com/open-telemetry/opentelemetry-java-contrib/blob/main/gcp-auth-extension/src/main/java/io/opentelemetry/

Why it is needed - gcp-auth-extension in otel adds auth to all exporters, once fixed, we will be able to remove this module.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@stankiewicz
Copy link
Copy Markdown
Contributor Author

R: @kennknowles

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new extension module for Apache Beam that enables GCP authentication for OpenTelemetry OTLP exporters. By leveraging Google Application Default Credentials (ADC), this extension automatically configures exporters to include the necessary authorization headers when communicating with GCP telemetry endpoints, facilitating seamless integration with Google Cloud monitoring and tracing services.

Highlights

  • New Module Addition: Added a new module opentelemetry-gcp-auth-extension to provide GCP authentication support for OTLP exporters.
  • Build Configuration: Updated BeamModulePlugin.groovy to include necessary OpenTelemetry dependencies and registered the new module in settings.gradle.kts.
  • Authentication Logic: Implemented GcpAuthAutoConfigurationCustomizerProvider to handle ADC retrieval and inject authorization headers into OTLP exporters.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new extension module, opentelemetry-gcp-auth-extension, to provide GCP authentication support for OpenTelemetry OTLP exporters in Apache Beam. The review feedback highlights several critical improvements: lazily retrieving Google Application Default Credentials (ADC) to prevent application startup crashes when ADC is not configured and GCP is not targeted; avoiding resource leaks by ensuring the original exporters are shut down when new ones are built; preventing potential NullPointerExceptions during header flattening; and refining endpoint checks to avoid noisy warnings when non-GCP endpoints are used.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@stankiewicz stankiewicz force-pushed the otel_gcp_auth branch 3 times, most recently from 8c6b2a1 to 8a86e09 Compare June 3, 2026 11:34
@kennknowles
Copy link
Copy Markdown
Member

Are there classes that can be @Internal if they are not meant for users - since we want to change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants