Fix Community Metrics Prober job#39290
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses issues in the Community Metrics Prober job by enforcing secure connections to the Grafana endpoint and fixing minor syntax errors in the test suite. These changes ensure the health checks remain reliable and follow current security best practices. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the ProberTests class by correcting a typo in the class documentation, switching the Grafana endpoint to HTTPS, and updating the collection size checks from .size to .size(). The review feedback suggests leveraging 'Groovy Truth' (e.g., assert dashboardNames and assert alerts) instead of checking .size() > 0. This is more idiomatic in Groovy and safer, as it avoids potential NullPointerExceptions if the collections are null.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| // Validate at least one expected dashboard exists | ||
| assert dashboardNames.contains('Post-commit Test Reliability') : 'Expected dashboard does not exist' | ||
| assert dashboardNames.size > 0 : "No dashboards found. Check Grafana dashboard initialization script." | ||
| assert dashboardNames.size() > 0 : "No dashboards found. Check Grafana dashboard initialization script." |
There was a problem hiding this comment.
In Groovy, you can leverage "Groovy Truth" to check if a collection is non-null and non-empty. Using assert dashboardNames is more idiomatic and safer as it avoids potential NullPointerException if the collection is null, throwing a clear AssertionError instead.
assert dashboardNames : "No dashboards found. Check Grafana dashboard initialization script."
| def alertsJson = "${grafanaEndpoint}/api/alerts?dashboardQuery=Source%20Data%20Freshness".toURL().text | ||
| def alerts = new JsonSlurper().parseText(alertsJson) | ||
| assert alerts.size > 0 | ||
| assert alerts.size() > 0 |
There was a problem hiding this comment.
In Groovy, you can leverage "Groovy Truth" to check if a collection is non-null and non-empty. Using assert alerts is more idiomatic and safer as it avoids potential NullPointerException if alerts is null, throwing a clear AssertionError instead.
assert alerts
2 participants
Fixes #33066
Successful run: https://github.com/apache/beam/actions/runs/29121034328/job/86455939450
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.