Skip to content

Fix scio docker #39291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Amar3tto merged 1 commit into from
Jul 13, 2026
+16 −6
Merged

Fix scio docker #39291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions playground/backend/containers/scio/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,21 @@ COPY --from=build /go/src/playground/backend/new_scio_project.sh /opt/playground
COPY --from=build /go/src/playground/backend/internal/fs_tool/ExampleData.scala /opt/playground/backend/
RUN chmod +x /opt/playground/backend/new_scio_project.sh

# Install sbt
RUN echo "deb https://repo.scala-sbt.org/scalasbt/debian all main" | tee /etc/apt/sources.list.d/sbt.list &&\
echo "deb https://repo.scala-sbt.org/scalasbt/debian /" | tee /etc/apt/sources.list.d/sbt_old.list &&\
curl -sL "https://keyserver.ubuntu.com/pks/lookup?op=get&search=0x2EE0EA64E40A89B84B2DF73499E82A75642AC823" | apt-key add
RUN apt-get update && apt-get install -y sbt
# Install sbt 1.x
RUN apt-get update \
&& apt-get install -y --no-install-recommends \
ca-certificates \
curl \
gnupg \
&& mkdir -p /etc/apt/keyrings \
&& curl -fsSL \
"https://keyserver.ubuntu.com/pks/lookup?op=get&search=0x2EE0EA64E40A89B84B2DF73499E82A75642AC823" \
| gpg --dearmor -o /etc/apt/keyrings/scalasbt.gpg \
Comment on lines +62 to +64

@gemini-code-assist gemini-code-assist Bot Jul 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using a pipe (|) with curl can lead to silent failures because the default shell (/bin/sh) does not have pipefail enabled by default. If the curl command fails (e.g., due to network issues or keyserver downtime), the pipeline might still exit with a success status, leading to an empty or corrupted keyring file and causing harder-to-debug failures later in the build process.

To prevent this, download the key to a temporary file first, dearmor it, and then remove the temporary file.

    && curl -fsSL "https://keyserver.ubuntu.com/pks/lookup?op=get&search=0x2EE0EA64E40A89B84B2DF73499E82A75642AC823" -o /tmp/scalasbt.key \
    && gpg --dearmor -o /etc/apt/keyrings/scalasbt.gpg /tmp/scalasbt.key \
    && rm /tmp/scalasbt.key \

&& echo "deb [signed-by=/etc/apt/keyrings/scalasbt.gpg] https://repo.scala-sbt.org/scalasbt/debian all main" \
> /etc/apt/sources.list.d/sbt.list \
&& apt-get update \
&& apt-get install -y --no-install-recommends sbt=1.10.11 \
&& rm -rf /var/lib/apt/lists/*

COPY src/properties.yaml /opt/playground/backend/properties.yaml
COPY entrypoint.sh /
Expand All @@ -83,7 +93,7 @@ RUN chown -R appuser:appgroup /opt/sbt-template
ARG DEBIAN_FRONTEND=noninteractive
RUN apt-get update \
&& apt-get install -y --no-install-recommends unzip \
&& rm -rf /var/lib/apt/lists/* \
&& rm -rf /var/lib/apt/lists/*

#Download spotify g8 template at specific commit
#ARG g8_commit=7c1ba7c1651dfd70976028842e721da4107c0d6d
Expand Down
Loading