Fix CdapIO dependency#39393
Conversation
* Add resolveCapabilitiesConflict * Bump cdap-api to 6.11.4
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the CDAP dependency version to 6.11.4 and introduces a configuration change to resolve dependency conflicts related to the lz4 library within the CDAP IO module. These changes ensure compatibility and stability for the CDAP connector. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the CDAP version to 6.11.4 and adds a configuration block to resolve a capabilities conflict in the CDAP Java IO SDK. The review feedback correctly identifies that the module notation for 'at.yawk.lz4' is incomplete because it lacks the artifact ID, and suggests correcting it to 'at.yawk.lz4:lz4-java' to ensure proper conflict resolution.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
||
| // spark3_streaming depends on old 'org.lz4:lz4-java'; conflict with kafka-clients:3.9.2 | ||
| configurations.all { | ||
| resolveCapabilitiesConflict(it, 'org.lz4:lz4-java', 'at.yawk.lz4') |
There was a problem hiding this comment.
The module notation 'at.yawk.lz4' is incomplete as it only specifies the group ID. It should include the artifact ID as well, which is 'at.yawk.lz4:lz4-java'. Passing an incomplete module notation will prevent the capability conflict resolution helper from correctly identifying and resolving the conflict.
resolveCapabilitiesConflict(it, 'org.lz4:lz4-java', 'at.yawk.lz4:lz4-java')
There was a problem hiding this comment.
I think this technically could help, but is unnecessary -
|
Assigning reviewers: R: @chamikaramj for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Add resolveCapabilitiesConflict
Bump cdap-api to 6.11.4
Please add a meaningful description for your change here
Follow up #39284
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.