[GSoC 2026] Kafka Streams runner: enable ParDoTest in the ValidatesRunner suite#39451
Merged
je-ik merged 1 commit intoJul 23, 2026
Conversation
…nner suite Adds Beam's ParDoTest suites to the validatesRunner task, taking it from 26 to 44 tests: BasicTests (6), MultipleInputsAndOutputTests (5), TimestampTests (4) and LifecycleTests (3). MultipleInputsAndOutputTests passes on the multi-output executable stages added in apache#39410. The remaining ParDoTest nested classes fall out on category excludes the task already declares. TestKafkaStreamsRunner.run now restates a failed run as a PipelineExecutionException carrying the exception the user's code threw, instead of letting the Kafka Streams wrapper naming the failed processor node surface. RuntimeException(Throwable) derives its message from the cause, so the user's message ends up on the thrown exception, which is what Beam's contract for run() and the tests asserting on a DoFn throwing expect to see. SparkPipelineResult and DirectRunner restate failures the same way. The existing unwrap that rethrows a failed PAssert's AssertionError still runs first. Sickbays testParDoWithErrorInStartBatch: a DoFn whose @StartBundle throws never reports its error, because SdkHarnessClient.newBundle sends the ProcessBundleRequest and then blocks in GrpcDataService.createOutboundAggregator waiting for a data stream that a bundle failing during setup never opens, so the run blocks for the data service's three-minute timeout. That is shared java-fn-execution behaviour; the Flink runner sickbays all of LifecycleTests and the Prism runner sickbays each of its three error tests.
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Contributor
|
Assigning reviewers: R: @chamikaramj added as fallback since no labels match configuration Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
je-ik
merged commit Jul 23, 2026
b615ae8
into
apache:feat/18479-kafka-streams-runner-skeleton
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #18479.
Enables Beam's
ParDoTestsuites in the Kafka Streams runner'svalidatesRunnertask, which takes the suite from 26 to 44 tests.What runs now
ParDoTest$BasicTestsParDoTest$MultipleInputsAndOutputTestsParDoTest$TimestampTestsParDoTest$LifecycleTestsMultipleInputsAndOutputTestspasses on the multi-output executable stages that landed in #39410. The remainingParDoTestnested classes (state, timers, timer families, bundle finalization, and the side-input half ofMultipleInputsAndOutputTests) fall out on category excludes the task already declares, so no new excludes were needed.Surfacing a failed run as
PipelineExecutionExceptionThe three
LifecycleTestserror tests assert that a DoFn throwing surfaces as aRuntimeExceptioncarrying the user's message. What came out ofTestKafkaStreamsRunner.runinstead was the raw Kafka Streams wrapper:The user's exception is at the bottom of that chain, under several layers of bundle- and Fn-API-level wrappers.
runnow restates a failed run asPipeline.PipelineExecutionExceptioncarrying the root cause, so the user's message ends up on the thrown exception —RuntimeException(Throwable)derives its message from the cause.SparkPipelineResultandDirectRunnerrestate failures the same way. The existing unwrap that rethrows anAssertionError(a failedPAssert) still runs first.That fixes
testParDoWithErrorInProcessElementandtestParDoWithErrorInFinishBatch.One sickbay
testParDoWithErrorInStartBatchis sickbayed. A DoFn whose@StartBundlethrows never gets to report its error:SdkHarnessClient.newBundlesends theProcessBundleRequestand then blocks inGrpcDataService.createOutboundAggregatorwaiting for the SDK harness to open its data stream, which a bundle that failed during setup never does. The run blocks for the data service's three-minute timeout instead of surfacing the user's exception.This is shared
java-fn-executionbehaviour rather than anything specific to this runner — the Flink runner sickbays all ofLifecycleTests, and the Prism runner sickbays each of its three error tests. The@ProcessElementand@FinishBundlevariants do pass here, because by then the data stream is established.Testing