Skip to content

Enable discovery of log_handler tests.#3946

Closed
robertwb wants to merge 1 commit intoapache:masterfrom
robertwb:yet-more-grpc-fixes
Closed

Enable discovery of log_handler tests.#3946
robertwb wants to merge 1 commit intoapache:masterfrom
robertwb:yet-more-grpc-fixes

Conversation

@robertwb
Copy link
Contributor

@robertwb robertwb commented Oct 5, 2017

Also fix the one remaining bug.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Also fix the one remaining bug.
@robertwb
Copy link
Contributor Author

robertwb commented Oct 5, 2017

R: @herohde @kennknowles

@kennknowles
Copy link
Member

LGTM

1 similar comment
@herohde
Copy link
Contributor

herohde commented Oct 5, 2017

LGTM

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 566d6e1 on robertwb:yet-more-grpc-fixes into ** on apache:master**.

@asfgit
Copy link

asfgit commented Oct 5, 2017

SUCCESS

--none--

@asfgit asfgit closed this in 1259ee9 Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants