Skip to content

[GSoC 2026] Kafka Streams runner: ask for primitive reads in the Java wrapper - #39766

Open
junaiddshaukat wants to merge 1 commit into
apache:feat/18479-kafka-streams-runner-skeletonfrom
junaiddshaukat:feat/ks-use-deprecated-read
Open

[GSoC 2026] Kafka Streams runner: ask for primitive reads in the Java wrapper#39766
junaiddshaukat wants to merge 1 commit into
apache:feat/18479-kafka-streams-runner-skeletonfrom
junaiddshaukat:feat/ks-use-deprecated-read

Conversation

@junaiddshaukat

Copy link
Copy Markdown
Contributor

Part of #18479. Follows up #39752 (comment).

A Read expands into a splittable DoFn by default, which this runner does not translate, so a pipeline that merely reads would fail to translate unless it knew to call SplittableParDo.convertReadBasedSplittableDoFnsToPrimitiveReads itself. The measurement application does exactly that, which is what prompted the question.

KafkaStreamsRunner now sets use_deprecated_read and converts the pipeline before handing it to the portable runner, so the proto that reaches the job server already holds primitive reads.

Worth being precise about what each half does. Beam already converts unless a pipeline asked for splittable reads, so the change that matters is that the runner calls the conversion at all; the experiment covers the case where a pipeline asks for use_sdf_read, which this runner cannot honour. There is a test for each, and each fails if its half is removed.

This is the Java wrapper only. A Python pipeline builds its proto client-side and does not pass through here.

… wrapper

A Read expands into a splittable DoFn by default and the runner cannot
translate one, so a pipeline that merely reads failed to translate unless it
knew to convert the reads itself.

The wrapper now sets use_deprecated_read and converts the pipeline before
handing it on, so a pipeline does not have to know, and a pipeline that asks
for splittable reads still gets primitive ones rather than something that
cannot run.
@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @damccorm added as fallback since no labels match configuration

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant